Skip to content

Fix ApacheHttpClient Proxy Preemptive Auth Failure #6333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 13, 2025
Merged

Fix ApacheHttpClient Proxy Preemptive Auth Failure #6333

merged 7 commits into from
Aug 13, 2025
+164 −2

Conversation

S-Saranya1
Copy link
Contributor

@S-Saranya1 S-Saranya1 commented Aug 12, 2025 •
edited
Loading

Fix ApacheHttpClient proxy authentication failure issue with preemptive authentication.

Motivation and Context

Users configuring proxy preemptive authentication with preemptiveBasicAuthenticationEnabled set to true were experiencing 407 error which was not expected.

Fixes #5884

Modifications

Added synthetic challenge processing in addPreemptiveAuthenticationProxy() method to initialize BasicScheme for preemptive authentication

Testing

Added unit test to verify preemptive authentication functionality

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@S-Saranya1 S-Saranya1 requested a review from a team as a code owner August 12, 2025 16:59
@S-Saranya1 S-Saranya1 changed the title Fix proxy preemptive auth failure Fix ApacheHttpClient proxy preemptive auth failure Aug 12, 2025
@S-Saranya1 S-Saranya1 changed the title Fix ApacheHttpClient proxy preemptive auth failure Fix ApacheHttpClient Proxy Preemptive Auth Failure Aug 12, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
62.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@S-Saranya1 S-Saranya1 added this pull request to the merge queue Aug 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2025
@S-Saranya1 S-Saranya1 added this pull request to the merge queue Aug 13, 2025
Merged via the queue into master with commit c18207f Aug 13, 2025
40 of 42 checks passed
@github-actions GitHub Actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2025
@S-Saranya1 S-Saranya1 deleted the somepal/fix-proxy-preemptive-auth-header branch August 14, 2025 00:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RanVaknin RanVaknin RanVaknin approved these changes

@alextwoods alextwoods alextwoods approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ApacheHttpClient Proxy Authentication fails
3 participants
@S-Saranya1 @RanVaknin @alextwoods